Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case test_drain_with_block_for_eviction_success #1733

Conversation

chriscchien
Copy link
Contributor

@chriscchien chriscchien commented Feb 19, 2024

Add test case test_drain_with_block_for_eviction_success

ref: 7521

Which issue(s) this PR fixes:

Issue #7521

What this PR does / why we need it:

Test case only have skeleton

Special notes for your reviewer:

10 times test result

Additional documentation or context

N/A

@chriscchien chriscchien self-assigned this Feb 19, 2024
@chriscchien chriscchien requested a review from a team as a code owner February 19, 2024 12:17
@chriscchien
Copy link
Contributor Author

chriscchien commented Feb 20, 2024

Add test case test_drain_with_block_for_eviction_if_contains_last_replica_success

10 times test result

I will fix the CodeFacor issue later, thank you.

@chriscchien chriscchien force-pushed the test_drain_with_block_for_eviction_success branch 11 times, most recently from 84de17d to f1ec914 Compare February 20, 2024 10:35
@chriscchien chriscchien removed the request for review from a team February 20, 2024 10:35
@chriscchien chriscchien force-pushed the test_drain_with_block_for_eviction_success branch 2 times, most recently from 4eb6a4b to 8feda8b Compare February 21, 2024 12:46
@chriscchien chriscchien force-pushed the test_drain_with_block_for_eviction_success branch from 8feda8b to b489201 Compare February 21, 2024 12:51
@chriscchien
Copy link
Contributor Author

Test case have potential fail rate if the drain node have backup store located, need invetigate after longhorn/longhorn#8004

error: unable to drain node "ip-10-0-2-211" due to error:cannot delete Pods declare no controller (use --force to override): default/longhorn-test-minio, continuing command...
There are pending nodes to be drained:

@chriscchien chriscchien force-pushed the test_drain_with_block_for_eviction_success branch from 3d527e3 to 2f3ad3e Compare February 23, 2024 10:10
@chriscchien
Copy link
Contributor Author

Add test case test_drain_with_block_for_eviction_failure and test result here

Need test again after #1744 merged

@chriscchien
Copy link
Contributor Author

10 times test of below test cases all passed

  • test_drain_with_block_for_eviction_failure
  • test_drain_with_block_for_eviction_success
  • test_drain_with_block_for_eviction_if_contains_last_replica_success

@chriscchien chriscchien requested a review from a team February 26, 2024 06:16
Copy link
Member

@yangchiu yangchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangchiu yangchiu merged commit 75dfb43 into longhorn:master Feb 26, 2024
5 checks passed
@chriscchien
Copy link
Contributor Author

@mergify backport v1.6.x

Copy link

mergify bot commented Feb 26, 2024

backport v1.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants